Thread (18 messages) 18 messages, 6 authors, 2024-06-20

Re: [PATCH 1/3] version: refactor strbuf_sanitize()

From: Eric Sunshine <hidden>
Date: 2024-06-19 18:40:27

On Wed, Jun 19, 2024 at 8:57 AM Christian Couder
[off-list ref] wrote:
The git_user_agent_sanitized() function performs some sanitizing to
avoid special characters being sent over the line and possibly messing
up with the protocol or with the parsing on the other side.

Let's extract this sanitizing into a new strbuf_sanitize() function, as
we will want to reuse it in a following patch.

For now the new strbuf_sanitize() function is still static as it's only
needed locally.

While at it, let's also make a few small improvements:
  - use 'size_t' for 'i' instead of 'int',
  - move the declaration of 'i' inside the 'for ( ... )',
  - use strbuf_detach() to explicitely detach the string contained by
    the 'buf' strbuf.
s/explicitely/explicitly/
Signed-off-by: Christian Couder <redacted>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help