Thread (1 message) 1 message, 1 author, 2024-06-11

Re: [PATCH v6 2/3] fetch-pack: expose fsckObjects configuration logic

From: Junio C Hamano <hidden>
Date: 2024-06-11 19:20:27

"Xing Xin via GitGitGadget" [off-list ref] writes:
-	if (fetch_fsck_objects >= 0
-	    ? fetch_fsck_objects
-	    : transfer_fsck_objects >= 0
-	    ? transfer_fsck_objects
-	    : 0)
-		fsck_objects = 1;
+	fsck_objects = fetch_pack_fsck_objects();
...
+int fetch_pack_fsck_objects(void)
+{
+	fetch_pack_setup();
OK, this one is designed to be as lightweight as possible when it
has already been called, so a potentially duplicated call would not
cause too much worries here.
+	if (fetch_fsck_objects >= 0)
+		return fetch_fsck_objects;
+	if (transfer_fsck_objects >= 0)
+		return transfer_fsck_objects;
+	return 0;
+}
Much easier to follow.  Nicely done.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help