Re: [PATCH 1/4] Makefile: extract script to lint missing/extraneous manpages

"James Liu" [off-list ref] writes:

On Wed Jun 5, 2024 at 3:27 PM AEST, Patrick Steinhardt wrote:

quoted

On Tue, Jun 04, 2024 at 10:20:54PM -0700, Junio C Hamano wrote:

quoted

Patrick Steinhardt [off-list ref] writes:

quoted

+++ b/Documentation/lint-manpages.sh

@@ -0,0 +1,82 @@
+#!/usr/bin/env bash

I do not see much bash-ism here.  Unless absolutely needed, please
use "#!/bin/sh" instead.

Ah, true. I initially did have some bash-isms, but got rid of them. Will
adapt.

Patrick

It looks like the script fails to run under /bin/sh:
https://gitlab.com/gitlab-org/git/-/jobs/7021474555#L4365

Nice to know.  In any case, the original was an inline scriptlet in
the Makefile and should have been happily working for folks whose
/bin/sh is different from bash, so the version that is extracted out
shouldn't have to rely on bashisms.

Thanks.