Thread (3 messages) 3 messages, 3 authors, 2024-05-25

Re: [PATCH v3 1/1] macOS: ls-files path fails if path of workdir is NFD

From: Torsten Bögershausen <hidden>
Date: 2024-05-25 20:01:34

On Fri, May 24, 2024 at 12:33:08AM +0900, Jun. T wrote:
Unfortunately v3 still doesn't work.
'git ls-files NFD' works but 'git ls-files NFC' does not.

I think it better to test both "ls-config NFD" and "ls-config NFC".

The reason of the failure seems to be the same as v2, but
I describe it here in more detail (or too detailed).
Thanks for testing - I was fully convinced that the new test case
did cover all problems - but proved to be wrong.

[snip the nice analyses]
I don't know how to fix the problem, but I think it better to avoid
calling precompose_{strbuf,string}_if_needed() before commondir
is set to ".git" and .git/config is successfully read.

Or reset the_repository->config->hash_initialized at some point?
I think that I may be able to offer a v4 patch, which has better test cases.
From my understanding, the reading of the local/repo .git/config does
not work as we need it, since the .git/ directroy is determined after
the config has been read. And so it is never read.
Having said that, a patch relying on the global .gitconfig may still
be an improvement on it's own.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help