Re: [PATCH 4/6] update-ref: add support for 'symref-create' command
From: Patrick Steinhardt <hidden>
Date: 2024-05-16 11:09:36
On Tue, May 14, 2024 at 02:44:09PM +0200, Karthik Nayak wrote:
quoted hunk ↗ jump to hunk
From: Karthik Nayak <redacted>diff --git a/refs.c b/refs.c index c2c9889466..6b724343fe 100644 --- a/refs.c +++ b/refs.c@@ -1302,15 +1302,16 @@ int ref_transaction_update(struct ref_transaction *transaction, int ref_transaction_create(struct ref_transaction *transaction, const char *refname, const struct object_id *new_oid, + const char *new_target, unsigned int flags, const char *msg, struct strbuf *err) { - if (!new_oid || is_null_oid(new_oid)) { - strbuf_addf(err, "'%s' has a null OID", refname); + if ((!new_oid || is_null_oid(new_oid)) && !new_target) { + strbuf_addf(err, "'%s' has a null OID or no new target", refname); return 1; }
Shouldn't this be "'%s' has neither an OID nor a target"? Also, we again miss `new_oid && new_target`.
quoted hunk ↗ jump to hunk
diff --git a/t/t0600-reffiles-backend.sh b/t/t0600-reffiles-backend.sh index a390cffc80..cc7e20431e 100755 --- a/t/t0600-reffiles-backend.sh +++ b/t/t0600-reffiles-backend.sh@@ -468,4 +468,36 @@ test_expect_success POSIXPERM 'git reflog expire honors core.sharedRepository' ' esac ' +test_expect_success SYMLINKS 'symref transaction supports symlinks' ' + test_when_finished "git symbolic-ref -d TESTSYMREFONE" && + git update-ref refs/heads/new @ && + test_config core.prefersymlinkrefs true && + cat >stdin <<-EOF && + start + symref-create TESTSYMREFONE refs/heads/new
Let's future proof this and create the ref with a name that matches our root ref restrictions, like "TEST_SYMREF_HEAD". We do plan to enforce those soonish, so these tests would break. Patrick
Attachments
- signature.asc [application/pgp-signature] 833 bytes