Thread (77 messages) 77 messages, 4 authors, 2024-05-15

Re: [PATCH 19/21] builtin/config: track "fixed value" option via flags only

From: Eric Sunshine <hidden>
Date: 2024-05-11 16:52:17

On Sat, May 11, 2024 at 8:11 AM Patrick Steinhardt [off-list ref] wrote:
We track the "fixed value" option via two separate bits: once via the
global variable `fixed_value`, and once via the CONFIG_FLAGS_FIXED_VALUE
bit in `flags`. This is confusing and may easily lead to issues when one
is not aware that this is tracked via two separate mechanisms.

Refactor the code to use the flag exclusively. We already pass it to all
the require callsites anyway, except for `collect_config()`.
s/require/required/
Signed-off-by: Patrick Steinhardt <redacted>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help