[PATCH 01/13] reftable/block: use `size_t` to track restart point index
From: Patrick Steinhardt <hidden>
Date: 2024-05-08 11:03:49
Subsystem:
the rest · Maintainer:
Linus Torvalds
The function `block_reader_restart_offset()` gets the offset of the `i`th restart point. `i` is a signed integer though, which is certainly not the correct type to track indices like this. Furthermore, both callers end up passing a `size_t`. Refactor the code to use a `size_t` instead. Signed-off-by: Patrick Steinhardt <redacted> --- reftable/block.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/reftable/block.c b/reftable/block.c
index 5942cb4053..00030eee06 100644
--- a/reftable/block.c
+++ b/reftable/block.c@@ -326,9 +326,9 @@ int block_reader_first_key(const struct block_reader *br, struct strbuf *key) return 0; } -static uint32_t block_reader_restart_offset(const struct block_reader *br, int i) +static uint32_t block_reader_restart_offset(const struct block_reader *br, size_t idx) { - return get_be24(br->restart_bytes + 3 * i); + return get_be24(br->restart_bytes + 3 * idx); } void block_iter_seek_start(struct block_iter *it, const struct block_reader *br)
--
2.45.0
Attachments
- signature.asc [application/pgp-signature] 833 bytes