Re: [PATCH 3/3] add: use advise_if_enabled for ADVICE_ADD_EMBEDDED_REPO
From: Rubén Justo <hidden>
Date: 2024-03-29 19:59:35
From: Rubén Justo <hidden>
Date: 2024-03-29 19:59:35
On Fri, Mar 29, 2024 at 12:31:30PM -0700, Junio C Hamano wrote:
Rubén Justo [off-list ref] writes:quoted
quoted
This one also needs a similar justification, but with a twist.May I ask what you would find a good justification? Perhaps "newer" -> "now preferred"?That is merely shifting justification around. You'd now need to answer: Why do you consider it preferred?
Because it's newer ;-D Maybe I'll point to the commit where advise_if_enabled() was introduced, b3b18d1621 (advice: revamp advise API, 2020-03-02). We have some arguments there. I'll sleep on it.