Re: [PATCH v2] t4126: fix "funny directory name" test on Windows (again)
From: Jeff King <hidden>
Date: 2024-03-29 18:34:32
From: Jeff King <hidden>
Date: 2024-03-29 18:34:32
On Fri, Mar 29, 2024 at 10:21:58AM -0700, Junio C Hamano wrote:
Even though "git update-index --cacheinfo" ought to be filesystem
agnostic,
$ git update-index --add --cacheinfo "100644,$empty_blob,funny /empty"
fails only on Windows, and this unfortunately makes the approach of
the previous step unworkable.
Resurrect the earlier approach to give up on running the test on
known-bad platforms. Instead of computing a custom prerequisite,
just use !MINGW we have used elsewhere.Thanks, this looks good to me. You mentioned FUNNYNAMES earlier (which I forgot even existed). That would probably work in practice, but it is kind of overloaded already. I think using MINGW here gets to the point, and as you note, if some other platforms fails we'd want to hear about it. -Peff