Thread (2 messages) 2 messages, 2 authors, 2024-03-27

GSoC 2024 [RFC PATCH]

From: Aishwarya Narayanan <hidden>
Date: 2024-03-27 13:04:55
Subsystem: the rest · Maintainer: Linus Torvalds

Dear Git Organization,

I hope this email finds you well. I've prepared a patch to address an
issue related to the handling of exit codes in our test suite. The
changes ensure that the exit code of the write_utf16 and write_utf32
functions is properly captured and not suppressed, improving the
reliability of our testing process.
Below are the details of the patch:

---
 t/t0028-working-tree-encoding.sh | 11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)
diff --git a/t/t0028-working-tree-encoding.sh b/t/t0028-working-tree-encoding.sh
index ad151a3467..f372c14bc0 100755
--- a/t/t0028-working-tree-encoding.sh
+++ b/t/t0028-working-tree-encoding.sh
@@ -19,10 +19,13 @@ test_expect_success 'setup test files' '
  echo "*.utf16 text working-tree-encoding=utf-16" >.gitattributes &&
  echo "*.utf16lebom text working-tree-encoding=UTF-16LE-BOM"
quoted
.gitattributes &&
  printf "$text" >test.utf8.raw &&
- printf "$text" | write_utf16 >test.utf16.raw &&
- printf "$text" | write_utf32 >test.utf32.raw &&
- printf "\377\376"                         >test.utf16lebom.raw &&
- printf "$text" | iconv -f UTF-8 -t UTF-16LE >>test.utf16lebom.raw &&
+ test_utf16_raw=$(printf "$text" | write_utf16) &&
+ test_utf32_raw=$(printf "$text" | write_utf32) &&
+ test_utf16lebom_raw=$(printf "\377\376"; printf "$text" | iconv -f
UTF-8 -t UTF-16LE) &&
+ echo "$test_utf16_raw" > test.utf16.raw &&
+ echo "$test_utf32_raw" > test.utf32.raw &&
+ echo "$test_utf16lebom_raw" > test.utf16lebom.raw &&
+

  # Line ending tests
  printf "one\ntwo\nthree\n" >lf.utf8.raw &&
-- 

I kindly request your review and any remarks or changes you may have.
Please accept my apologies for any mistakes or oversights.

Thank you for your time and attention.

Best regards, Aishwarya Narayanan
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help