Thread (5 messages) 5 messages, 4 authors, 2024-03-27

Re: [PATCH v2 16/16] config: allow multi-byte core.commentChar

From: Jeff King <hidden>
Date: 2024-03-27 07:47:02

Possibly related (same subject, not in this thread)

On Tue, Mar 26, 2024 at 03:10:23PM -0700, Junio C Hamano wrote:
It has been 10 days since this discussion petered out.
I wrote the last message, so I was waiting for you to respond. ;)

  https://lore.kernel.org/git/20240316055013.GA32145@coredump.intra.peff.net/ (local)
My preference is to introduce core.commentString to avoid confusion
coming from an older Git using the first-byte of a multi-byte
string, or dying upon reading a configuration file meant for a newer
Git, and then let core.commentString override core.commentChar, but
I would prefer to see the discussion participants to raise their
opinions and reach a conclusion.
OK. I don't have a strong opinion. Are you OK with core.commentString as
a strict synonym (so last-one-wins and either name overwrites previous)?
Or do you want an override (i.e., commentString always overrides
commentChar, regardless of order). I think it's mostly academic, and the
strict synonym version is much easier to implement.

-Peff
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help