Thread (1 message) 1 message, 1 author, 2024-03-14

Re: [PATCH v2 3/5] merge options: add a conflict style member

From: Junio C Hamano <hidden>
Date: 2024-03-14 17:21:47

"Phillip Wood via GitGitGadget" [off-list ref] writes:
quoted hunk
--- a/merge-ll.c
+++ b/merge-ll.c
@@ -128,7 +128,9 @@ static enum ll_merge_result ll_xdl_merge(const struct ll_merge_driver *drv_unuse
 	xmp.level = XDL_MERGE_ZEALOUS;
 	xmp.favor = opts->variant;
 	xmp.xpp.flags = opts->xdl_opts;
-	if (git_xmerge_style >= 0)
+	if (opts->conflict_style >= 0)
+		xmp.style = opts->conflict_style;
+	else if (git_xmerge_style >= 0)
 		xmp.style = git_xmerge_style;
The convention being negative ones are unknown/invalid/unspecified,
this if/else cascade makes sense.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help