Thread (1 message) 1 message, 1 author, 2024-03-13

Re: [PATCH v2 16/16] config: allow multi-byte core.commentChar

From: Junio C Hamano <hidden>
Date: 2024-03-13 18:39:48

"Kristoffer Haugsbakk" [off-list ref] writes:
quoted
+	(default '#'). Note that this option can take values larger than
+	a byte (whether a single multi-byte character, or you
+	could even go wild with a multi-character sequence).
I don’t know if this expanded description focuses a bit much on the
history of the change[1] or if it is intentionally indirect about this
char-is-really-a-string behavior as a sort of easter egg.[2]
Maybe it could be more directly stated like:

  “ Note that this variable can in fact be a string like `foo`; it
    doesn’t have to be a single character.

(Hopefully UTF-8 is implied by “foo”. Or else “føø”.)
That's definitely an improvement, but I would say that using a
dingbat instad of "foo", and "single character" -> "single ASCII
character" (or "single byte") would make it even clearer.

Thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help