RE: [PATCH v1 2/4] builtin/receive-pack.c: change xwrite to write_in_full to allow large sizes.
From: <hidden>
Date: 2024-02-26 23:02:20
On Monday, February 26, 2024 5:06 PM, I wrote:
From: "Randall S. Becker" <redacted> This change is required because some platforms do not support file writes
of arbitrary sizes (e.g, NonStop). xwrite ends up truncating
the output to the maximum single I/O size possible for the destination
device.
quoted hunk ↗ jump to hunk
Signed-off-by: Randall S. Becker <redacted> --- builtin/receive-pack.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)diff --git a/builtin/receive-pack.c b/builtin/receive-pack.c index
db65607485..5064f3d300 100644
quoted hunk ↗ jump to hunk
--- a/builtin/receive-pack.c +++ b/builtin/receive-pack.c@@ -455,8 +455,9 @@ static void report_message(const char *prefix, const
char *err, va_list params)
if (use_sideband)
send_sideband(1, 2, msg, sz, use_sideband);
- else
- xwrite(2, msg, sz);
+ else {
+ write_in_full(2, msg, sz);
+ }
}
__attribute__((format (printf, 1, 2)))
--
2.42.1
This needs to be fixed, so the {} after the else is removed. Will be in v2.