Thread (5 messages) 5 messages, 3 authors, 2024-02-22

Re: [PATCH v2] rebase: make warning less passive aggressive

From: Kristoffer Haugsbakk <hidden>
Date: 2024-02-22 10:53:32

On Wed, Feb 21, 2024, at 18:38, Harmen Stoppels via GitGitGadget wrote:
From: Harmen Stoppels <redacted>

When you run `git rebase --continue` when no rebase is in progress, git
outputs `fatal: No rebase in progress?` which is not a question but a
statement. Make it appear as a statement, and use lowercase to align
with error message style.

Signed-off-by: Harmen Stoppels <redacted>
---
I’ve interpreted this error as: I’m not quite sure but it looks like you
are not in the middle of a rebase? Like it can’t be completely
sure. Maybe from a more “primitive” time, implementation-wise?[1] :)

(I waited to make this reply in order to see what others would say. And
apparently there is no need for a hedging/passive aggressive question
mark.)

† 1: 031321c654d (Add --continue and --abort options to git-rebase.,
    2006-04-26)

-- 
Kristoffer Haugsbakk
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help