Thread (6 messages) 6 messages, 3 authors, 2024-06-07

Re: [PATCH 2/2] apply: rewrite unit tests with structured cases

From: Kristoffer Haugsbakk <hidden>
Date: 2024-02-19 22:04:44

On Mon, Feb 19, 2024, at 05:45, Philip Peterson via GitGitGadget wrote:
From: Philip Peterson <redacted>

The imperative format was a little hard to read, so I rewrote the test cases
in a declarative style by defining a common structure for each test case and
its assertions.

Signed-off-by: Philip Peterson <redacted>
IMO in general you can just assert that X and Y in the commit message.

  “ The imperative format is hard to read. Rewrite the test cases …

If your patch passes review and is merged then that’s the truth as
determined by you and the reviewers.

More subjective-sounding “This was hard to read” and maybe anecdotes
like “this tripped me up when reading” can go outside the commit message
like the cover letter or the free-form space between the commit message
and the patch (after the three-hyphen/three-dash lines).

-- 
Kristoffer Haugsbakk
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help