Thread (1 message) 1 message, 1 author, 2024-02-14

Re: [PATCH v2 4/4] rev-list: allow missing tips with --missing=[print|allow*]

From: Junio C Hamano <hidden>
Date: 2024-02-14 16:49:53

Christian Couder [off-list ref] writes:
quoted
quoted
quoted
+            /* Already add missing tips */
+            oidset_insert_from_set(&missing_objects, &revs.missing_commits);
+            oidset_clear(&revs.missing_commits);
+    }
It is unclear what "already" here refers to, at least to me.
I wanted to hint that we already have some missing objects that we can
add to the set. But it's not an important detail and I agree it can be
confusing.
I was confused primarily because "already" was not sitting next to
"missing".  I would have understood "Add already-missing tips" just
fine ;-)
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help