[PATCH v3 2/2] column: guard against negative padding
From: Kristoffer Haugsbakk <hidden>
Date: 2024-02-13 16:02:06
Subsystem:
the rest · Maintainer:
Linus Torvalds
Make sure that client code can’t pass in a negative padding by accident.
Suggested-by: Rubén Justo <redacted>
Signed-off-by: Kristoffer Haugsbakk <redacted>
---
Notes (series):
Apparently these are the only publicly-visible functions that use this
struct according to `column.h`.
column.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/column.c b/column.c
index ff2f0abf399..50bbccc92ee 100644
--- a/column.c
+++ b/column.c@@ -182,6 +182,8 @@ void print_columns(const struct string_list *list, unsigned int colopts, { struct column_options nopts; + if (opts && (0 > opts->padding)) + BUG("padding must be non-negative"); if (!list->nr) return; assert((colopts & COL_ENABLE_MASK) != COL_AUTO);
@@ -361,6 +363,8 @@ int run_column_filter(int colopts, const struct column_options *opts) { struct strvec *argv; + if (opts && (0 > opts->padding)) + BUG("padding must be non-negative"); if (fd_out != -1) return -1;
--
2.43.0