Thread (2 messages) 2 messages, 2 authors, 2024-02-01

Re: [PATCH v3 03/10] trailer: unify trailer formatting machinery

From: Junio C Hamano <hidden>
Date: 2024-02-01 17:48:46

Linus Arver [off-list ref] writes:
Josh Steadmon [off-list ref] writes:
quoted
On 2024.01.31 01:22, Linus Arver via GitGitGadget wrote:
quoted
This unification will allow us to delete the format_trailer_info() and
print_tok_val() functions in the next patch. They are not deleted here
in order to keep the diff small.
Needs to be removed after squashing v2 patch 4 :)
Oops. Will update in next reroll, thanks.
FWIW, by the way, having them in the same patch made it a lot easier
to compare what the original did (with these removed functions) and
what the updated code would do.  When a change is supposed to be a
clean-up of an existing code without changing the behaviour, it helps
to make the before and after versions visible in the patch.

Thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help