Re: sd/negotiate-trace-fix

Josh Steadmon [off-list ref] writes:

On 2024.01.19 17:56, Junio C Hamano wrote:
[snip]

quoted

* sd/negotiate-trace-fix (2024-01-03) 1 commit
 - push: region_leave trace for negotiate_using_fetch

 Tracing fix.

 Waiting for a review response.
 cf. <xmqqbka27zu9.fsf@gitster.g>
 source: [ref]

Hi Junio,

Were there other open questions you had on this series? It looks like
Sam answered all the questions in your xmqqbka27zu9.fsf@gitster.g reply.

Thanks for a reminder.

In your other followup you mentioned running CI with tracing enabled for
all tests. This is something that we suggested before [1] but it was
pretty thoroughly rejected for runtime reasons. Perhaps a more efficient
check for region_enter/leave pairs could be an option, though.

Yeah, perhaps.  It does not sound like an issue that must block this
patch in either case.

Thanks.