Thread (1 message) 1 message, 1 author, 2024-01-18

Re: [PATCH 03/12] t1414: convert test to use Git commands instead of writing refs manually

From: Junio C Hamano <hidden>
Date: 2024-01-18 00:56:28

"John Cai via GitGitGadget" [off-list ref] writes:
 # Create a situation where the reflog and ref database disagree about the latest
 # state of HEAD.
-test_expect_success REFFILES 'walk prefers reflog to ref tip' '
+test_expect_success 'walk prefers reflog to ref tip' '
+	test_commit A &&
+	test_commit B &&
+	git reflog delete HEAD@{0} &&
 	head=$(git rev-parse HEAD) &&
+	A=$(git rev-parse A) &&
 
+	echo $A >expect &&
You do not need an intermediate variable A, i.e.

	git rev-parse A >expect &&

would suffice.  Also it seems that $head is no longer used
because you do not manufacture a reflog entry yourself, so the two
assignments to $A and $head can be removed.
 	git log -g --format=%H -1 >actual &&
 	test_cmp expect actual
 '
The resulting code makes the intent of the test much clearer.
Nicely done.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help