Re: [PATCH] t4129: prevent loss of exit code due to the use of pipes
From: Junio C Hamano <hidden>
Date: 2024-01-10 17:25:12
"Chandra Pratap via GitGitGadget" [off-list ref] writes:
t/t4129-apply-samemode.sh | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)
Looks good. Will queue with two instances of a minor style fix (see below).
quoted hunk
diff --git a/t/t4129-apply-samemode.sh b/t/t4129-apply-samemode.sh index e7a7295f1b6..ffabeafa213 100755 --- a/t/t4129-apply-samemode.sh +++ b/t/t4129-apply-samemode.sh@@ -41,7 +41,8 @@ test_expect_success FILEMODE 'same mode (index only)' ' chmod +x file && git add file && git apply --cached patch-0.txt && - git ls-files -s file | grep "^100755" + git ls-files -s file > ls-files-output &&
Redirection operator ">" and "<" sticks to the file in question (look for "> " and "< " in this file and you'd find none), i.e. git ls-files -s file >ls-files-output && Thanks.