Re: [PATCH 4/8] SubmittingPatches: update extra tags list
From: Josh Soref <hidden>
Date: 2023-12-20 17:42:58
Subsystem:
documentation, the rest · Maintainers:
Jonathan Corbet, Linus Torvalds
Elijah Newren wrote:
Yeah, well it appears that those of us who have been here in Rome for a while aren't a fan of it anymore either; see also Junio's response in this thread about that.
Right.
[Josh Soref [off-list ref] wrote:]quoted
Given that Noticed-by is more common than Co-authored-by, I have a hard time arguing that it shouldn't be included.Not if you look at the last three years; there Co-authored-by is more than 17 times more common than Noticed-by.
Given the large drop-off in usage of the Noticed-by trailer, I'd suggest just leaving it out.
Perhaps replace You can also create your own tag or use one that's in common usage such as "Thanks-to:", "Based-on-patch-by:", or "Mentored-by:". with While you can also create your own trailer if the situation warrants it, we encourage you to instead use one of the common trailers in this project highlighted above. ?
Let's have some fun (inception):
commit eac2211332f754c5f4127a58aafb9882bfe939e8
Author: Josh Soref [off-list ref]
Date: Wed Dec 20 12:34:54 2023 -0500
SubmittingPatches: discourage new trailers
There seems to be consensus amongst the core Git community on a working
set of common trailers, and there are non-trivial costs to people
inventing new trailers (research to discover what they mean/how they
differ from existing trailers) such that inventing new ones is generally
unwarranted and not something to be recommended to new contributors.
Suggested-by: Elijah Newren [off-list ref]
Signed-off-by: Josh Soref [off-list ref]
diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches
index 32e9023877..58dfe40504 100644
--- a/Documentation/SubmittingPatches
+++ b/Documentation/SubmittingPatches@@ -358,4 +358,5 @@ If you like, you can put extra tags at the end: -You can also create your own tag or use one that's in common usage -such as "Thanks-to:", "Based-on-patch-by:", or "Mentored-by:". +While you can also create your own trailer if the situation warrants it, we +encourage you to instead use one of the common trailers in this project +highlighted above.