Thread (29 messages) 29 messages, 3 authors, 2023-12-14

Re: [PATCH 0/4] refs: improve handling of special refs

From: Patrick Steinhardt <hidden>
Date: 2023-11-30 07:46:58

On Wed, Nov 29, 2023 at 05:14:39PM -0500, Taylor Blau wrote:
On Wed, Nov 29, 2023 at 09:14:07AM +0100, Patrick Steinhardt wrote:
quoted
Patrick Steinhardt (4):
  wt-status: read HEAD and ORIG_HEAD via the refdb
  refs: propagate errno when reading special refs fails
  refs: complete list of special refs
  bisect: consistently write BISECT_EXPECTED_REV via the refdb

 bisect.c                    | 25 +++------------
 builtin/bisect.c            |  8 ++---
 refs.c                      | 64 +++++++++++++++++++++++++++++++++++--
 t/t1403-show-ref.sh         |  9 ++++++
 t/t6030-bisect-porcelain.sh |  2 +-
 wt-status.c                 | 17 +++++-----
 6 files changed, 86 insertions(+), 39 deletions(-)
These all look pretty good to me. I had a few minor questions on the
first three patches, but I don't think they necessarily require a
reroll.
I agree that none of the comments really require a reroll, but I'll
address them if there will be another iteration of this patch series.

Thanks for your review! 

Patrick

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help