Re: [PATCH 1/1] attr: enable attr pathspec magic for git-add and git-stash
From: Eric Sunshine <hidden>
Date: 2023-11-04 06:28:39
Possibly related (same subject, not in this thread)
- 2023-11-10 · Re: [PATCH 1/1] attr: enable attr pathspec magic for git-add and git-stash · Joanna Wang <hidden>
- 2023-11-09 · Re: [PATCH 1/1] attr: enable attr pathspec magic for git-add and git-stash · Junio C Hamano <hidden>
- 2023-11-04 · Re: [PATCH 1/1] attr: enable attr pathspec magic for git-add and git-stash · Junio C Hamano <hidden>
- 2023-11-03 · [PATCH 1/1] attr: enable attr pathspec magic for git-add and git-stash · Joanna Wang <hidden>
- 2023-11-03 · Re: [PATCH 1/1] attr: enable attr pathspec magic for git-add and git-stash · Ruben Safir <hidden>
On Sat, Nov 4, 2023 at 1:12 AM Junio C Hamano [off-list ref] wrote:
quoted
+ if ((magic & pathspec_magic[i].bit) && (pathspec_magic[i].mnemonic != '\0')) {Overly long, with a stylo. Here is what I ended up queuing. + for (int i = 0; i < ARRAY_SIZE(pathspec_magic); i++) { + if ((magic & pathspec_magic[i].bit) && + (pathspec_magic[i].mnemonic)) {
Nit: The no-value-added parentheses around `pathspec_magic[i].mnemonic` can also be dropped.