Thread (3 messages) 3 messages, 2 authors, 2023-10-31

Re: [PATCH] sequencer: remove use of comment character

From: Tony Tung <hidden>
Date: 2023-10-31 04:43:06

On Oct 30, 2023, at 4:35 PM, Junio C Hamano [off-list ref] wrote:

Elijah Newren [off-list ref] writes:
quoted
I thought the point of the comment_line_char was so that commit
messages could have lines starting with '#'.  That rationale doesn't
apply to the TODO list generation or parsing, and I'm not sure if we
want to add the same complexity there.
Thanks for a healthy dose of sanity.  I noticed existing use of
comment_line_char everywhere in sequencer.c and assumed we would
want to be consistent, but you are right to point out that they are
all about the COMMIT_EDITMSG kind of thing, and not about what
appears in "sequencer/todo”.
I believe comment_line_char is being applied when the sequencer reads back the instructions, which is why I ran into this problem to begin with.

If the intent is not to apply it to the sequencer, then the bugfix is in the wrong place.

Thanks
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help