Re: [PATCH v5 3/5] bulk-checkin: introduce `index_blob_bulk_checkin_incore()`
From: Eric Sunshine <hidden>
Date: 2023-10-25 17:22:04
From: Eric Sunshine <hidden>
Date: 2023-10-25 17:22:04
On Wed, Oct 25, 2023 at 11:44 AM Taylor Blau [off-list ref] wrote:
On Wed, Oct 25, 2023 at 09:58:06AM +0200, Patrick Steinhardt wrote:quoted
On Mon, Oct 23, 2023 at 06:45:01PM -0400, Taylor Blau wrote:quoted
In order to support streaming from a location in memory, we must implement a new kind of bulk_checkin_source that does just that. These implementation in spread out across:Nit: the commit message is a bit off here. Probably not worth a reroll though.Your eyes are definitely mine, because I'm not seeing where the commit message is off! But hopefully since you already don't think it's worth a reroll, and I'm not even sure what the issue is that we can just leave it ;-).
Perhaps:
s/implementation in/implementations are/