Thread (1 message) 1 message, 1 author, 2023-10-19

Re: Is there any interest in localizing term delimiters in git messages?

From: Junio C Hamano <hidden>
Date: 2023-10-19 20:17:04

Torsten Bögershausen [off-list ref] writes:
The switch case covers all 8 values of "enum crlf_action",
and removing these 2 lines
 -	warning("Illegal crlf_action %d\n", (int)crlf_action);
 -	return core_eol;
does still compile without a compiler warning.
So yes, a BUG is more appropriate here.
Yeah, and if our expectation is whenever we add a new value to enum
convert_crlf_action, we will handle in and return from the switch
statement, so I agree with you that BUG() is more appropriate.

Thanks for a quick response.  Note that this was something we
discovered while talking about i18n and no immediate action is
required---it is not like we saw a report that tells us that end
users are actively getting confused by this message.

Thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help