Thread (2 messages) 2 messages, 2 authors, 2023-10-19

Re: [PATCH v3 08/10] bulk-checkin: introduce `index_blob_bulk_checkin_incore()`

From: Taylor Blau <hidden>
Date: 2023-10-19 15:30:56

On Wed, Oct 18, 2023 at 04:18:23PM -0700, Junio C Hamano wrote:
Taylor Blau [off-list ref] writes:
quoted
Now that we have factored out many of the common routines necessary to
index a new object into a pack created by the bulk-checkin machinery, we
can introduce a variant of `index_blob_bulk_checkin()` that acts on
blobs whose contents we can fit in memory.
Hmph.

Doesn't the duplication between the main loop of the new
deflate_obj_contents_to_pack() with existing deflate_blob_to_pack()
bother you?
Yeah, I am not sure how I missed seeing the opportunity to clean that
up. Another (hopefully final...) reroll incoming.

Thanks,
Taylor
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help