On 2023-10-12 at 17:49:13, Eric Sunshine wrote:

quoted

+       sz = strtoumax(argv[2], &p, 0);
+       if (*p)
+               die("invalid size");

Do you want to check 'errno' here, as well (probably before the '*p' check)?

Or is that being too defensive for a 'test-tool' command?

I don't believe that's necessary.  The Linux manual page leads me to
believe that if *argv[2] is not 0 but *p is 0, then the entire string is
valid, which would imply that errno is not set.  I'm happy to ignore for
the moment the case where the user specifies "" as the argument, because
it is a test helper and "don't do weird, unexpected things with the test
helper without looking at the source code first" is legitimate advice
for Git developers.

If this were user-facing, improved robustness would be warranted, I
agree.
-- 
brian m. carlson (he/him or they/them)
Toronto, Ontario, CA