Re: [PATCH v8 2/3] unit tests: add TAP unit test framework
From: Junio C Hamano <hidden>
Date: 2023-10-11 21:42:52
Subsystem:
the rest · Maintainer:
Linus Torvalds
Possibly related (same subject, not in this thread)
- 2023-11-01 · Re: [PATCH v8 2/3] unit tests: add TAP unit test framework · Josh Steadmon <hidden>
- 2023-10-27 · Re: [PATCH v8 2/3] unit tests: add TAP unit test framework · Christian Couder <hidden>
- 2023-10-09 · [PATCH v8 2/3] unit tests: add TAP unit test framework · Josh Steadmon <hidden>
Josh Steadmon [off-list ref] writes:
+ /* Initialized strbufs should always have a non-NULL buffer */ + if (buf->buf == NULL) + return 0;
This upsets Coccinelle (equals-null). I'll queue this on top for now to work around CI breakage. Thanks. ----- >8 ----- Subject: [PATCH] SQUASH??? Coccinelle suggested style fix. --- t/unit-tests/t-strbuf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/t/unit-tests/t-strbuf.c b/t/unit-tests/t-strbuf.c
index c2fcb0cbd6..8388442426 100644
--- a/t/unit-tests/t-strbuf.c
+++ b/t/unit-tests/t-strbuf.c@@ -28,7 +28,7 @@ static void setup_populated(void (*f)(struct strbuf*, void*), char *init_str, vo static int assert_sane_strbuf(struct strbuf *buf) { /* Initialized strbufs should always have a non-NULL buffer */ - if (buf->buf == NULL) + if (!buf->buf) return 0; /* Buffers should always be NUL-terminated */ if (buf->buf[buf->len] != '\0')
--
2.42.0-345-gaab89be2eb