Re: [PATCH v4 11/15] replay: use standard revision ranges

On Thu, Sep 7, 2023 at 1:02 PM Johannes Schindelin
[off-list ref] wrote:

Hi Christian,

It is a bit surprising to see the manual page added in _this_ patch, in
the middle of the series... I can live with it, though.

It's explained in the cover letter and a bit in some commit messages.

For example in the "Possibly controversial issues" section of the
cover letter, there is:

"
* when and where to add tests and docs: although t6429 has tests that
  are changed to use the new command instead of the fast-rebase
  test-tool command as soon as the former is introduced, there is no
  specific test script and no doc for the new command until commit
  11/15 when standard revision ranges are used. This is done to avoid
  churn in tests and docs while the final form of the command hasn't
  crystalized enough. Adding tests and doc at this point makes this
  commit quite big and possibly more difficult to review than if they
  were in separate commits though. On the other hand when tests and
  docs are added in specific commits, some reviewers say it would be
  better to introduce them when the related changes are made.
"

On Thu, 7 Sep 2023, Christian Couder wrote:

quoted

+SYNOPSIS
+--------
+[verse]
+'git replay' --onto <newbase> <revision-range>...

We need to make it clear here, already in the SYNOPSIS, that this is
experimental. Let's add an `(EXPERIMENTAL!)` prefix here.

I haven't done that as other commands marked as EXPERIMENTAL don't
have that in their SYNOPSIS.

quoted

[...]

diff --git a/t/t3650-replay-basics.sh b/t/t3650-replay-basics.sh
new file mode 100755

Just like the manual page, I would have expected this test to be
introduced earlier, and not piggy-backed onto one of the handful "let's
turn fast-rebase into replay" patches.

This is discussed above.