Thread (1 message) 1 message, 1 author, 2023-10-06

Re: [PATCH v3 1/3] diff-merges: improve --diff-merges documentation

From: Junio C Hamano <hidden>
Date: 2023-10-06 23:19:48

Sergey Organov [off-list ref] writes:
Junio C Hamano [off-list ref] writes:
quoted
Elijah Newren [off-list ref] writes:
quoted
quoted
quoted
+--cc::
+     Produce dense combined diff output for merge commits.
+     Shortcut for '--diff-merges=dense-combined -p'.
Good.
quoted
+--remerge-diff::
+     Produce diff against re-merge.
+     Shortcut for '--diff-merges=remerge -p'.
...
Perhaps:

Produce remerge-diff output for merge commits, in order to show how
conflicts were resolved.
I do not mind it, but then I'd prefer to see ", in order to show
how" also in the description of "--cc" and "-c" for consistency.

A succinct way to say what they do may be hard to come by, but I
think of them showing places that did not have obvious natural
resolution.
So, is it OK with both of you if I leave it as:

"Produce remerge-diff output for merge commits."

for now, and let you tweak the descriptions later on, if needed?
I do not know what Elijah would say, but in one of iterations of my
draft response to him indeed suggested that "in order to" here is
not necessary if it is described for the "--diff-merges=remerge"
option, because those who know enough to skip referring to the other
entry are expected to know why it exists.  So I think I am OK with
that.

Thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help