Thread (1 message) 1 message, 1 author, 2023-10-06

Re: [PATCH 2/3] revision: clear decoration structs during release_revisions()

From: Junio C Hamano <hidden>
Date: 2023-10-06 16:45:14

Jeff King [off-list ref] writes:
On Thu, Oct 05, 2023 at 04:00:54PM -0700, Junio C Hamano wrote:
quoted
Wow, nested maze of callbacks make my head spin ;-) but they all
look reasonable.  Thanks.
Yeah, I don't love those one-liner callbacks just to handle the cast.

The other alternative is to write some kind of for_each_decoration()
macro, but I think it ends up in the usual macro hell (requiring the
caller to provide iterator variables, hanging half-open braces, and so
on). It might be worth it if iterating could be used in other places,
but I don't think it is.

So I tried to choose the lesser of two evils. :)
Oh, I am happy with the result.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help