Re: [PATCH 0/10] some commit-graph leak fixes
From: Taylor Blau <hidden>
Date: 2023-10-05 17:52:35
From: Taylor Blau <hidden>
Date: 2023-10-05 17:52:35
On Tue, Oct 03, 2023 at 04:25:04PM -0400, Jeff King wrote:
I noticed while working on the jk/commit-graph-verify-fix topic that free_commit_graph() leaks any slices of a commit-graph-chain except for the first. I naively hoped that fixing that would make t5324 leak-free, but it turns out there were a number of other leaks, so I fixed those, too. A couple of them were in the merge code, which in turn means a bunch of new test scripts are now leak-free. Even though I saw the problem on that other topic, there's no dependency here; this series can be applied directly to master (or possibly even maint, though I didn't try).
Thanks for carefully finding and explaining these various leaks. The series is a definite improvement, and after reviewing closely I couldn't find anything worth changing. LGTM! Thanks, Taylor