Re: [PATCH] builtin/repack.c: avoid making cruft packs preferred
From: Taylor Blau <hidden>
Date: 2023-10-03 16:30:19
From: Taylor Blau <hidden>
Date: 2023-10-03 16:30:19
On Tue, Oct 03, 2023 at 12:27:51PM -0400, Taylor Blau wrote:
I've had this sitting in my patch queue for a while now. It's a non-critical performance fix that avoids the repack/MIDX machinery from ever choosing a cruft pack as preferred when writing a MIDX bitmap without a given --preferred-pack. There is no correctness issue here, but choosing a pack with few/no reachable objects means that our pack reuse mechanism will rarely kick in, resulting in performance degradation. builtin/repack.c | 47 ++++++++++++++++++++++++++++++++++++++++- t/t7704-repack-cruft.sh | 39 ++++++++++++++++++++++++++++++++++ 2 files changed, 85 insertions(+), 1 deletion(-)
Oops, I should have mentioned that this is meant to be applied on top of 'tb/multi-cruft-pack' to reduce the conflict resolution burden. Sorry about that. Thanks, Taylor