Thread (1 message) 1 message, 1 author, 2023-09-21

Re: [PATCH v2 2/4] config: report config parse errors using cb

From: Junio C Hamano <hidden>
Date: 2023-09-21 23:36:43

Josh Steadmon [off-list ref] writes:
As Jonathan Tan mentioned in [1], on calling do_event() we set the start
offset of the new event, and execute the callback for the previous event
whose end offset we now know.

I refactored this into "start_event()" and "flush_event()" functions as
suggested, and added a new "do_event_and_flush()" function for the case
where we want to immediately execute a callback for an event.
Very nicely done.  Thanks, both.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help