Thread (1 message) 1 message, 1 author, 2023-09-18

Re: [PATCH v2] git-gui - re-enable use of hook scripts

From: Junio C Hamano <hidden>
Date: 2023-09-18 16:06:07

Johannes Schindelin [off-list ref] writes:
Sounds good. FWIW I ran a couple experiments here, too:

	% file pathtype "C:/foo"
	absolute
	% file pathtype ".git/hooks"
	relative
	% file pathtype ".git\\hooks"
	relative
	% file pathtype "/foo"
	volumerelative
	% file pathtype "foo"
	relative

The problem, therefore, is that `file pathtype` does not discern between a
bare file name and a relative path. The proposed patch looks correct to
me.

Thank you,
Johannes
Yup, the other "run hooks in a more modern way using 'git hook'"
patch is the right solution for the immediate breakage, but it still
cannot remove this sanitize_command_line proc as we have other users
and use cases where we want to use the sanitized $PATH search, so
this fix is still needed.

Thanks for a quick review on both patches.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help