Thread (7 messages) 7 messages, 4 authors, 2023-09-21

Re: [PATCH 2/2] parse-options: use and require int pointer for OPT_CMDMODE

From: Junio C Hamano <hidden>
Date: 2023-09-16 17:46:23

Possibly related (same subject, not in this thread)

Jeff King [off-list ref] writes:
quoted
True.  Though I don't fully understand these warnings (why not then
also warn about if without else?), but taking them away is a bit rude
to those who care.
I think losing warnings is unfortunate, but it's just one example.
We're losing the type information completely from the values.
...
quoted
Or to use an int to point to and then copy into a companion enum
variable to after parsing, which would be my choice.
Yeah, I had the same thought. I'm just not sure how to do that in a way
that isn't a pain for the callers.
The discussion seems to have petered out around this point.
What (if anything) do we want to do with this topic?
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help