Thread (72 messages) 72 messages, 8 authors, 2024-02-29

Re: [PATCH v3 2/6] wrapper: remove dependency to Git-specific internal file

flat view

From: Jonathan Tan <hidden>
Date: 2023-09-15 17:55:20

Calvin Wan [off-list ref] writes:
In order for wrapper.c to be built independently as part of a smaller
library, it cannot have dependencies to other Git specific
internals. remove_or_warn() creates an unnecessary dependency to
object.h in wrapper.c. Therefore move the function to entry.[ch] which
performs changes on the worktree based on the Git-specific file modes in
the index.
Looking at remove_or_warn(), it's only used from entry.c and apply.c
(which already includes entry.h for another reason) so moving it to
entry.c looks fine.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help