Re: [PATCH v2] completion: improve doc for complex aliases
From: Linus Arver <hidden>
Date: 2023-09-14 22:33:30
"Philippe Blain via GitGitGadget" [off-list ref] writes:
From: Philippe Blain <redacted>
The completion code can be told to use a particular completion for
aliases that shell out by using ': git <cmd> ;' as the first command of
the alias. This only works if <cmd> and the semicolon are separated by a
space, since if the space is missing __git_aliased_command returns (for
example) 'checkout;' instead of just 'checkout', and then
__git_complete_command fails to find a completion for 'checkout;'.
The examples have that space but it's not clear if it's just for
style or if it's mandatory. Explicitly mention it.
Signed-off-by: Philippe Blain <redacted>
---
completion: improve doc for complex aliases
Changes since v1:
* fixed the typo pointed out by Eric
* added an explanation of why the space is mandatory, as suggested by
LinusThanks for the investigation. The commit message reads much better now. This LGTM, but I think Junio's review comments [1] are worth considering. I'll respond there also. [1] https://lore.kernel.org/git/xmqqo7i6khxv.fsf@gitster.g/#t (local)