Thread (1 message) 1 message, 1 author, 2023-09-13

Re: [PATCH v2 2/2] completion: commit: complete trailers tokens more robustly

From: Junio C Hamano <hidden>
Date: 2023-09-13 00:34:29

"Philippe Blain via GitGitGadget" [off-list ref] writes:
From: Philippe Blain <redacted>

In the previous commit, we added support for completing configured
trailer tokens in 'git commit --trailer'.

Make the implementation more robust by:

- using '__git' instead of plain 'git', as the rest of the completion
  script does
- using a stricter pattern for --get-regexp to avoid false hits
- using 'cut' and 'rev' instead of 'awk' to account for tokens including
  dots.

Signed-off-by: Philippe Blain <redacted>
---
Thanks, both, for a quick fix.

Queued.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help