Thread (1 message) 1 message, 1 author, 2023-09-13

Re: [PATCH v2] sequencer: remove unreachable exit condition in pick_commits()

From: Junio C Hamano <hidden>
Date: 2023-09-13 00:32:55

Phillip Wood [off-list ref] writes:
On 12/09/2023 11:55, Oswald Buddenhagen wrote:
quoted
This was introduced by 56dc3ab04 ("sequencer (rebase -i): implement the
'edit' command", 2017-01-02), and was pointless from the get-go: all
early exits from the loop above are returns, so todo_list->current ==
todo_list->nr is an invariant after the loop.
Signed-off-by: Oswald Buddenhagen <redacted>
Thanks for updating the commit message, I think it is clearer now
Thanks, both.  Queued.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help