Thread (1 message) 1 message, 1 author, 2023-09-13

Re: [PATCH v2] t3404-rebase-interactive.sh: fix typos in title of a rewording test

From: Junio C Hamano <hidden>
Date: 2023-09-13 00:25:29

Phillip Wood [off-list ref] writes:
On 12/09/2023 11:42, Oswald Buddenhagen wrote:
quoted
This test was introduced by commit 0c164ae7a ("rebase -i: add another
reword test", 2021-08-20). I didn't quite get what it was meant to do,
so here's an explanation from Phillip:
The purpose of the test is to ensure that
   (i) There are no uncommited changes when the editor runs. I.e.,
we
       commit without running the editor and then reword by amending
       that commit. This ensures that we have the same user experience
       whether or not the commit was fast-forwarded [1].
  (ii) That the todo list is re-read after the commit has been
reworded.
       This is to allow the user to update the todo list while the rebase
       is paused for editing the commit message.
[1] https://lore.kernel.org/git/20190812175046.GM20404@szeder.dev/ (local)
Signed-off-by: Oswald Buddenhagen <redacted>
This looks good to me, Thanks

Phillip
Thanks, both.  Will queue.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help