Thread (1 message) 1 message, 1 author, 2023-09-11

Re: [PATCH v2 2/6] trailer: split process_input_file into separate pieces

From: Junio C Hamano <hidden>
Date: 2023-09-11 21:38:48

"Linus Arver via GitGitGadget" [off-list ref] writes:
From: Linus Arver <redacted>

Currently, process_input_file does three things:

    (1) parse the input string for trailers,
    (2) print text before the trailers, and
    (3) calculate the position of the input where the trailers end.

Rename this function to parse_trailers(), and make it only do
(1). The caller of this function, process_trailers, becomes responsible
for (2) and (3). These items belong inside process_trailers because they
are both concerned with printing the surrounding text around
trailers (which is already one of the immediate concerns of
process_trailers).
Nicely explained and the resulting code reads well.

Thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help