Re: [PATCH] rebase -i: ignore signals when forking subprocesses

Hi Phillip,

On Fri, 8 Sep 2023, Phillip Wood wrote:

On 07/09/2023 13:57, Johannes Schindelin wrote:

quoted

On Thu, 7 Sep 2023, Phillip Wood via GitGitGadget wrote:

quoted

     Having written this I started thinking about what happens when
     we fork hooks, merge strategies and merge drivers. I now wonder
     if it would be better to change run_command() instead - are
     there any cases where we actually want git to be killed when
     the user interrupts a child process?

I am not sure that we can rely on arbitrary hooks to do the right
thing upon Ctrl+C, which is to wrap up and leave. So I _guess_ that we
will have to leave it an opt-in.

Peff pointed out it doesn't play well with "gc --auto" either. Do you have any
thoughts (particularly about the implications for Windows) on his suggestion
to put the child in it's own session, or putting the child in its own process
group and making that the foreground process group of the controlling
terminal?

The concept of "sessions" does not really translate well into the Windows
world. Neither does the concept of a "process group".

Ciao,
Johannes