Re: [PATCH v3 12/15] replay: disallow revision specific options and pathspecs

From
Christian Couder <hidden>
Date
2023-09-07 17:51:33
Reply to
Junio C Hamano, 2023-07-25
On Tue, Jul 25, 2023 at 11:16 PM Junio C Hamano [off-list ref] wrote:
Christian Couder [off-list ref] writes:
quoted
+     /*
+      * Reject any pathspec. (They are allowed and eaten by
+      * setup_revisions() above.) In the future we might accept
+      * them, after adding related tests and doc though.
+      */
+     if (revs.prune_data.nr) {
+             error(_("invalid pathspec: %s"), revs.prune_data.items[0].match);
This made me waste a few minutes wondering if and how I misspelt my
pathspec elements.  If we mean "no pathspec is allowed", we should
say so instead.
Yeah, right. I have changed this to:

            error(_("no pathspec is allowed: '%s'"),
revs.prune_data.items[0].match);
quoted
+             usage_with_options(replay_usage, replay_options);
+     }
Thread (2 messages) 2 messages, 2 authors, last reply 2023-09-07
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help