Thread (1 message) 1 message, 1 author, 2023-09-06

Re: [PATCH] show doc: redirect user to git log manual instead of git diff-tree

From: Junio C Hamano <hidden>
Date: 2023-09-06 17:26:16

Han Young [off-list ref] writes:
quoted
Strictly speaking, "options to control how the changes are shown"
are options that are meant for "diff" command (e.g. "--stat", "-w"),
but "log" understands some of the "diff" command options, the
updated text is *not* incorrect.
On a closer look, the manual page of git show does lists
all the "diff" options by including diff-options.txt.
The options omitted are revision parsing related.
The primary difference between "log" and "show" is that the latter
is not about walking a range of commits.  Both grok "diff" related
options that control how the changes introduced by each commit are
shown equally well.  But in the context of "show", options that
control revision traversal (i.e. which commits are chosen to be
shown and in what order) do not make much sense.

So ...
Perhaps we remove the line
quoted
The command takes options applicable to the git diff-tree command to
control how the changes the commit introduces are shown.
And rephrase the line
quoted
This manual page describes only the most frequently used options.
to
quoted
 This manual page describes only the most frequently used options.
Some options that `git rev-list` command understands can be used to
control how commits are shown.
... I do not find the above an improvement.

Perhaps we should start with just "diff-tree" -> "log" and doing no
other damage to the existing text.  That will give us some baseline
that is a strict improvement.

Thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help