Re: [PATCH 8/8] parse-options: mark unused parameters in noop callback
From: Junio C Hamano <hidden>
Date: 2023-08-31 17:06:18
Jeff King [off-list ref] writes:
Unsurprisingly, the noop options callback doesn't bother to look at any of its parameters. Let's mark them so that -Wunused-parameter does not complain.
;-) Thanks.
quoted hunk
Another option would be to drop the callback and have parse-options itself recognize OPT_NOOP_NOARG. But that seems like extra work for no real benefit. Signed-off-by: Jeff King <redacted> --- parse-options-cb.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)diff --git a/parse-options-cb.c b/parse-options-cb.c index a24521dee0..bdc7fae497 100644 --- a/parse-options-cb.c +++ b/parse-options-cb.c@@ -227,7 +227,9 @@ int parse_opt_strvec(const struct option *opt, const char *arg, int unset) return 0; } -int parse_opt_noop_cb(const struct option *opt, const char *arg, int unset) +int parse_opt_noop_cb(const struct option *opt UNUSED, + const char *arg UNUSED, + int unset UNUSED) { return 0; }