Re: [PATCH 1/1] Fix the order of consuming unpackLimit config settings.

Looks good to me.

Thanks for the info on the patch process. I also am sending this mail
in plain text mode so hopefully the mailing list doesn't drop it.


On Tue, Aug 22, 2023 at 6:55 PM Junio C Hamano [off-list ref] wrote:

Taylor Santiago [off-list ref] writes:

quoted

Thank you! How would you like me to proceed? Should I submit the above as a
v2 of the earlier patch?

There is nothing "above" as you seem to be top posting ;-)

When somebody else helps by supplying an "squashable" patch, often
people are expected to review it and then update their patch(es)
using the given material to produce a v2.

But as I said, the "squashable" one was only about the receive-pack
side; even if you combined it with your original, tests for the
fetch side were still missing, so it was not sufficient for a v2.

As I didn't see your reply message (to which I am responding to)
until now, mostly because it was dropped by the mailing list
(perhaps it was an HTML e-mail from GMail or something???), I've
further worked on the tests to cover the fetch side and sent out a
full version (not a squashable, but just a replacement for the whole
thing).  It is archived and viewable at

  https://lore.kernel.org/git/xmqqpm3eh7f6.fsf@gitster.g (local)

Part of it is still your original patch, some material in its
proposed commit log message was given by Peff, and the rest was
written by me, so it carries names of three people.

If the result looks acceptable to you, then saying "Yup, that looks
good" would be the simplest answer to give to move things forward.

Thanks.